<html>
<head><meta charset="utf-8"><title>crater-run-review · t-compiler/wg-nll · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/index.html">t-compiler/wg-nll</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/crater-run-review.html">crater-run-review</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="130587106"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/crater-run-review/near/130587106" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/crater-run-review.html#130587106">(Jul 30 2018 at 15:38)</a>:</h4>
<p>I'm  going over the <a href="https://hackmd.io/2sR4vloZQhC8arJkFOFyLA?both" target="_blank" title="https://hackmd.io/2sR4vloZQhC8arJkFOFyLA?both">crater run notes</a> from <span class="user-mention" data-user-id="116113">@lqd</span>, trying to assess our current status. I thought I'd drop some notes in there and in here. (I'm not sure how long i'll be around anyway :)</p>



<a name="130587130"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/crater-run-review/near/130587130" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/crater-run-review.html#130587130">(Jul 30 2018 at 15:39)</a>:</h4>
<p>sadly, the minimized repro from argdata-0.0.4 still seems to be a problem with the July 30 nightly..</p>



<a name="130587132"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/crater-run-review/near/130587132" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/crater-run-review.html#130587132">(Jul 30 2018 at 15:39)</a>:</h4>
<p>..not sure if this has all the fixes?</p>



<a name="130587673"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/crater-run-review/near/130587673" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/crater-run-review.html#130587673">(Jul 30 2018 at 15:47)</a>:</h4>
<p>hmm, I see some that probably need issues filed</p>



<a name="130991740"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/crater-run-review/near/130991740" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/crater-run-review.html#130991740">(Aug 06 2018 at 17:17)</a>:</h4>
<p>so I've created this repository: <a href="https://github.com/nikomatsakis/nll-crater-run-results" target="_blank" title="https://github.com/nikomatsakis/nll-crater-run-results">https://github.com/nikomatsakis/nll-crater-run-results</a></p>



<a name="130991746"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/crater-run-review/near/130991746" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/crater-run-review.html#130991746">(Aug 06 2018 at 17:17)</a>:</h4>
<p>I'm going through the results</p>



<a name="130991765"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/crater-run-review/near/130991765" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/crater-run-review.html#130991765">(Aug 06 2018 at 17:17)</a>:</h4>
<p>encountered one very strange case, where I have reduced the test case to something small that fails with cargo, but it works when I move it to its own file (?)</p>



<a name="130991840"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/crater-run-review/near/130991840" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/crater-run-review.html#130991840">(Aug 06 2018 at 17:18)</a>:</h4>
<p>(this is the "shred" case)</p>



<a name="130991855"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/crater-run-review/near/130991855" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/crater-run-review.html#130991855">(Aug 06 2018 at 17:18)</a>:</h4>
<p>ah, woah</p>



<a name="130991859"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/crater-run-review/near/130991859" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/crater-run-review.html#130991859">(Aug 06 2018 at 17:18)</a>:</h4>
<p>it has to do with <code>crate-type lib</code> (!)</p>



<a name="130992140"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/crater-run-review/near/130992140" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/crater-run-review.html#130992140">(Aug 06 2018 at 17:23)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> how long does it take to do another crater run?</p>



<a name="130992150"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/crater-run-review/near/130992150" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/crater-run-review.html#130992150">(Aug 06 2018 at 17:23)</a>:</h4>
<p>seems like a lot of stuff is fixed, might be worth it</p>



<a name="130992159"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/crater-run-review/near/130992159" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/crater-run-review.html#130992159">(Aug 06 2018 at 17:23)</a>:</h4>
<p>are we doing that "in general" as part of EP2 etc?</p>



<a name="130994321"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/crater-run-review/near/130994321" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/crater-run-review.html#130994321">(Aug 06 2018 at 17:58)</a>:</h4>
<p>~24 hours for a check-only run, around 3 days for full build and test</p>



<a name="130995495"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/crater-run-review/near/130995495" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/crater-run-review.html#130995495">(Aug 06 2018 at 18:20)</a>:</h4>
<p>Yes, we'll be doing a general run as well</p>



<a name="130996989"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/crater-run-review/near/130996989" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/crater-run-review.html#130996989">(Aug 06 2018 at 18:49)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> well 1 day is not so bad. Maybe worth it. Not sure. I think we're down to 4 distinct bugs from the previous run</p>



<a name="130996994"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/crater-run-review/near/130996994" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/crater-run-review.html#130996994">(Aug 06 2018 at 18:49)</a>:</h4>
<p>I've filed issues on them now and put them into the Release Candidate triage category, anyway</p>



<a name="130996995"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/crater-run-review/near/130996995" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/crater-run-review.html#130996995">(Aug 06 2018 at 18:49)</a>:</h4>
<p>maybe it can wait</p>



<a name="130997061"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/crater-run-review/near/130997061" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/crater-run-review.html#130997061">(Aug 06 2018 at 18:50)</a>:</h4>
<p>I think both boxes are busy right now for another ~24-36 hours but craterbot is ready now so we can start builds trivially</p>



<a name="130997071"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/crater-run-review/near/130997071" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/crater-run-review.html#130997071">(Aug 06 2018 at 18:51)</a>:</h4>
<p>amazing</p>



<a name="130997078"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/crater-run-review/near/130997078" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/crater-run-review.html#130997078">(Aug 06 2018 at 18:51)</a>:</h4>
<p>craterbot!</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>